Stops Queen from stomping on Xenos with relevant pass flags (Lessers/Huggers/Larva) #6618
Conversation
| @@ -420,6 +420,8 @@ | |||
| /mob/living/carbon/xenomorph/queen/proc/check_block(mob/queen, turf/new_loc) | |||
| SIGNAL_HANDLER | |||
| for(var/mob/living/carbon/xenomorph/xeno in new_loc.contents) | |||
| if(xeno.pass_flags.flags_pass & PASS_MOB_THRU_XENO|PASS_MOB_THRU &! xeno.flags_pass_temp & PASS_MOB_THRU) | |||
There was a problem hiding this comment.
these binary operators look real weird, is &! xeno.flags_pass_temp & PASS_MOB_THRU meant to be resolving as && !(xeno.flags_pass_temp & PASS_MOB_THRU)?
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
Feel free to ask for reopen whenever above can be resolved. |
…(Lessers/Huggers/Larva) " (#7228) # About the pull request Revives the best PR ever made: #6618 It was closed because of GrrrKitten inactivity. # Explain why it's good for the game Getting stomp by queen when you do your task as lesser/facehugger/larva can be frustrating, it removes inconvinience. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: GrrrKitten qol: Stops Queen from stomping on xenos with relevant pass flags (Larva, Hugger, Lesser) /:cl:
About the pull request
Stops queen from stomping on Xenos that have relevant pass flags
Also in part fixes an issue that would occasionally cause dancer dodge to flip out
Important notes on this PR:
Explain why it's good for the game
QoL, just makes sense, prevents the poor baby larvas from getting squarshed
Requested by Venuska1117
Testing Photographs and Procedure
Screenshots & Videos
Don't feel like its necessary
Like the stuff I make?
Changelog
🆑
qol: Stops Queen from stomping on xenos with relevant pass flags (Larva, Hugger, Lesser)
/:cl: